[PATCH] D138623: [ADT] Deprecate llvm::NoneType

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 16:32:56 PST 2022


kazu added a comment.

In D138623#3948072 <https://reviews.llvm.org/D138623#3948072>, @MaskRay wrote:

> LGTM. `using` can be used as well, but the attribute is at a different place.
>
> MSVC supports `deprecated` for using/typedef but it doesn't warn about function arguments ([Facepalm]). g++/clang++ are good.

Ah, thank you for the explanation (and the review, of course)!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138623/new/

https://reviews.llvm.org/D138623



More information about the llvm-commits mailing list