[PATCH] D137882: [DWARFLibrary] Add support to re-construct cu-index

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo marked 6 inline comments as done.
ayermolo added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:2045
   }
-  const DWARFSection &getNamesSection() const override {
-    return NamesSection;
-  }
+  const DWARFSection &getNamesSection() const override { return NamesSection; }
 
----------------
dblaikie wrote:
> looks like this unrelated change snuck in?
Ah yeah clang-format change.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp:256-259
+DWARFUnitIndex::Entry::SectionContribution *
+DWARFUnitIndex::Entry::getContribution() {
+  return &Contributions[Index->InfoColumn];
+}
----------------
dblaikie wrote:
> ayermolo wrote:
> > dblaikie wrote:
> > > Should this return by reference?
> > I was trying to keep same return type as the const version. Changed to reference.
> oh, yeah, the other should probably change too... ifyou could do that in a separate patch, that'd be great
Sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137882/new/

https://reviews.llvm.org/D137882