[PATCH] D138594: [AMDGPU][MC] Refactor MC Code Emitter to avoid using magic values

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 12:49:11 PST 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp:237
     if (!MO.isImm())
-      return ~0;
+      return std::nullopt;
 
----------------
You can `return {}` if you prefer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138594/new/

https://reviews.llvm.org/D138594



More information about the llvm-commits mailing list