[PATCH] D138594: [AMDGPU][MC][NFC] Refactor MC Code Emitter to avoid using magic values

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 11:14:15 PST 2022


Joe_Nash added a comment.

I believe the latest guidance is to use std::Optional instead of llvm::Optional (https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716). Also it makes a difference in tests, so is not NFC. Otherwise looks good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138594/new/

https://reviews.llvm.org/D138594



More information about the llvm-commits mailing list