[PATCH] D138590: [mlir][index] Add and, or, and xor ops

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/Index/IR/IndexOps.td:354
+    The `index.and` operation takes two index values and computes their bitwise
+        and.
+
----------------
The formatting here looks off.


================
Comment at: mlir/include/mlir/Dialect/Index/IR/IndexOps.td:358-361
+    ```mlir
+         // c = a & b
+         %c = index.and %a, %b
+    ```
----------------



================
Comment at: mlir/include/mlir/Dialect/Index/IR/IndexOps.td:373
+    The `index.or` operation takes two index values and computes their bitwise
+        or.
+
----------------
Same as AndOp, and throughout this commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138590/new/

https://reviews.llvm.org/D138590