[PATCH] D138525: llvm-reduce: Reduce ifuncs

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/tools/llvm-reduce/remove-ifunc.ll:62
+define i32 @fn5(double %arg) {
+  %call = call i32 bitcast (float(i64)* @ifunc6 to float(i64)*)(double %arg)
+  ret i32 %call
----------------
aeubanks wrote:
> mixing `ptr` and `*` will just end up using opaque pointers everywhere, so this part is pointless
I'm constantly wondering if I should be trying to write code that bothers trying to work with typed pointers 


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceAliases.cpp:36
+      Constant *Resolver = GI.getResolver();
+      GI.replaceAllUsesWith(Resolver);
+      GI.eraseFromParent();
----------------
I'm wondering if it would be better to lower this by emitting a call to the resolver, plus the indirect call of the result


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138525/new/

https://reviews.llvm.org/D138525