[PATCH] D138542: [InstSimplify] Use dominate condtion to simplify instructions

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 06:59:29 PST 2022


bcl5980 added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:762
+    case Instruction::And:
+    case Instruction::Or:
+      return Op1;
----------------
I'm a little worry about the `and`/`or` part. Recursive call to isImpliedByDomCondition looks a little heavy.
I return Op1 here is because Op1 can be constant value but not sure it has any side effect or not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138542/new/

https://reviews.llvm.org/D138542



More information about the llvm-commits mailing list