[PATCH] D138451: [lld/mac] Add support for distributed thinlto

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/LTO.cpp:193
-                                   getArchitectureName(config->arch()) +
-                                   ".lto.o");
       saveOrHardlinkBuffer(objBuf, filePath, cachePath);
----------------
This here got extracted to the outputFilePath lambda, since I need this path in the index-only codepath as well.

(If desired, I could pull the minor refactoring and reordering in this function into its own patch. I figured it's small enough that that's not needed.)


================
Comment at: lld/MachO/LTO.cpp:247
     }
   }
 
----------------
This is moving up above the `pruneCache` call because I need objPathIsDir in the index only path, and the index-only handling happens before cache pruning. Moving this up should be safe.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138451/new/

https://reviews.llvm.org/D138451