[PATCH] D138561: [Assignment Tracking] Fix DbgVariableIntrinsic::replaceVariableLocationOp

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/unittests/IR/DebugInfoTest.cpp:417
+  // Replace both.
+  TEST_REPLACE(/*Old*/ P2, /*New*/ P1, /*Value*/ P1, /*Address*/ P1);
+
----------------
StephenTozer wrote:
> Might be worth also adding a test that it correctly asserts when trying to replace a value that does not appear in the address or value?
Rescinding this comment, testing the assert is probably not necessary in this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138561/new/

https://reviews.llvm.org/D138561