[PATCH] D137936: [AArch64] Optimize cmp chain before legalization

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 03:39:43 PST 2022


Allen marked an inline comment as done.
Allen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/bcmp.ll:432
 
+; https://www.godbolt.org/z/GMosfa1nc
+define i1 @bcmp_zext(i32 %0, i32 %1, i8 %2, i8 %3) {
----------------
dmgreen wrote:
> We don't usually put godbolt links in the source.
> 
> I see the new code is a little larger. They wouldn't be if the inputs were loaded or known to be smaller already though. And they don't fail, which was the main point of adding them.
Deleted, thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137936/new/

https://reviews.llvm.org/D137936



More information about the llvm-commits mailing list