[PATCH] D138470: [bazel] Restore libpfm as a conditional dependency for exegesis.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:2707
+
 cc_library(
     name = "Exegesis",
----------------
GMNGeoffrey wrote:
> gchatelet wrote:
> > AFAIU it doesn't make sense to build `Exegesis` without `libpfm` so I would do something similar to
> > https://github.com/llvm/llvm-project/blob/ee82b864f2086f944f046bd00b03f30697403f8a/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel#L13-L16
> > 
> > This makes sure that the target is skipped when using wildcards (which is the case on CI).
> I think it's fine to have it without? That's what we had before this patch
No strong opinion here, I'm fine with the status quo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138470/new/

https://reviews.llvm.org/D138470