[PATCH] D138545: [VectorCombine] Enable scalarizeBinopOrCmp for scalable vectors

[Matt Devereau via Phabricator via llvm-commits]

MattDevereau created this revision.
MattDevereau added reviewers: peterwaller-arm, spatel.
Herald added a subscriber: hiraditya.
Herald added a project: All.
MattDevereau requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, alextsao1999.
Herald added a project: LLVM.

[VectorCombine] Enable scalarizeBinopOrCmp for scalable vectors

      

This reverts a change to exclude scalarizeBinopOrCmp in VectorCombine for
scalable vectors which caused poor scalable Binop codegen.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138545

Files:
  llvm/lib/Transforms/Vectorize/VectorCombine.cpp
  llvm/test/Transforms/VectorCombine/AArch64/scalarize-scalable.ll


Index: llvm/test/Transforms/VectorCombine/AArch64/scalarize-scalable.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/VectorCombine/AArch64/scalarize-scalable.ll
@@ -0,0 +1,24 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -passes=vector-combine -S %s | FileCheck %s
+
+define <vscale x 4 x float> @scalarize_scalable(float %0, float %1, float %2, float %3) {
+; CHECK-LABEL: @scalarize_scalable(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    [[DOTSCALAR:%.*]] = fadd fast float [[TMP1:%.*]], [[TMP0:%.*]]
+; CHECK-NEXT:    [[DOTSCALAR1:%.*]] = fadd fast float [[TMP2:%.*]], [[DOTSCALAR]]
+; CHECK-NEXT:    [[DOTSCALAR2:%.*]] = fadd fast float [[TMP3:%.*]], [[DOTSCALAR1]]
+; CHECK-NEXT:    [[TMP4:%.*]] = insertelement <vscale x 4 x float> poison, float [[DOTSCALAR2]], i64 0
+; CHECK-NEXT:    [[TMP5:%.*]] = shufflevector <vscale x 4 x float> [[TMP4]], <vscale x 4 x float> poison, <vscale x 4 x i32> zeroinitializer
+; CHECK-NEXT:    ret <vscale x 4 x float> [[TMP5]]
+;
+entry:
+  %broadcast.splatinsert = insertelement <vscale x 4 x float> poison, float %0, i64 0
+  %broadcast.splatinsert28 = insertelement <vscale x 4 x float> poison, float %1, i64 0
+  %broadcast.splatinsert30 = insertelement <vscale x 4 x float> poison, float %2, i64 0
+  %broadcast.splatinsert32 = insertelement <vscale x 4 x float> poison, float %3, i64 0
+  %4 = fadd fast <vscale x 4 x float> %broadcast.splatinsert28, %broadcast.splatinsert
+  %5 = fadd fast <vscale x 4 x float> %broadcast.splatinsert30, %4
+  %6 = fadd fast <vscale x 4 x float> %broadcast.splatinsert32, %5
+  %7 = shufflevector <vscale x 4 x float> %6, <vscale x 4 x float> poison, <vscale x 4 x i32> zeroinitializer
+  ret <vscale x 4 x float> %7
+}
Index: llvm/lib/Transforms/Vectorize/VectorCombine.cpp
===================================================================
--- llvm/lib/Transforms/Vectorize/VectorCombine.cpp
+++ llvm/lib/Transforms/Vectorize/VectorCombine.cpp
@@ -1717,10 +1717,13 @@
         MadeChange |= scalarizeLoadExtract(I);
         break;
       default:
-        MadeChange |= scalarizeBinopOrCmp(I);
         break;
       }
     }
+
+    if (isa<VectorType>(I.getType()))
+      MadeChange |= scalarizeBinopOrCmp(I);
+
     if (Opcode == Instruction::Store)
       MadeChange |= foldSingleElementStore(I);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138545.477397.patch
Type: text/x-patch
Size: 2391 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221123/6098d80a/attachment.bin>