[PATCH] D133552: [RISCV] Add cost model for integer and float vector arithmetic instructions.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:918
+    return BaseT::getArithmeticInstrCost(Opcode, Ty, CostKind, Op1Info,
+                                         Op2Info);
+  }
----------------
reames wrote:
> You have a bug here - you didn't pass through the last two parameters and thus get the defaults when calling the base class version of the function.
> 
> I found this when iterating on a local version of this patch with the intention of subsetting and giving feedback on the remaining part. I went ahead and landed the plumbing for this change as d2cf0bd7 
OK, thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133552/new/

https://reviews.llvm.org/D133552