[PATCH] D137730: [mlir][TilingInterface] Fix a crash in PartialTilingInterface for some inputs

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/test/Dialect/Linalg/transform-tile-reduction.mlir:216
+
+transform.sequence failures(suppress) {
+^bb0(%arg1: !pdl.operation):
----------------
you may want to add a comment that this is supposed to fail gracefully and not change the IR


================
Comment at: mlir/test/Dialect/Linalg/transform-tile-reduction.mlir:222
+    
+// //   CHECK-DAG: #[[$MAP0:.*]] = affine_map<(d0, d1, d2) -> (d0, d2)>	
+// //   CHECK-DAG: #[[$MAP1:.*]] = affine_map<(d0, d1, d2) -> (d0, d1)>	
----------------
double comments here and below


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137730/new/

https://reviews.llvm.org/D137730