[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

We're seeing a CMake error after this:

  CMake Error at /data/users/smeenai/Source/tcdev/external/llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cmake:368 (add_library):
    Error evaluating generator expression:
  
      $<TARGET_OBJECTS:RTGwpAsan.x86_64>
  
    Objects of target "RTGwpAsan.x86_64" referenced but no such target exists.

What appears to be happening is that `COMPILER_RT_SCUDO_STANDALONE_BUILD_SHARED` is ON by default, as is `COMPILER_RT_BUILD_GWP_ASAN`. However, `gwp_asan` isn't actually built unless it's also present in `COMPILER_RT_SANITIZERS_TO_BUILD`, so the combination of defaults is broken.

One option would be to add `gwp_asan` to `COMPILER_RT_SANITIZERS_TO_BUILD` if `COMPILER_RT_BUILD_GWP_ASAN` is ON, as in P8299 <https://reviews.llvm.org/P8299>. Another would be to make Scudo consider `COMPILER_RT_SANITIZERS_TO_BUILD` in addition to `COMPILER_RT_HAS_GWP_ASAN` before linking the GWP-ASan libraries. What are your thoughts here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138157/new/

https://reviews.llvm.org/D138157