[PATCH] D136949: [Debugify] Accumulate the number of variables in debugify metadata
Anton Sidorenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 22 22:58:45 PST 2022
asi-sc added a comment.
In D136949#3945729 <https://reviews.llvm.org/D136949#3945729>, @xiangzhangllvm wrote:
> Yes, We use XFAIL to mark a test as an expected failure. An XFAIL test will be successful if its execution fails, and will be a failure if its execution succeeds.
> But now we are not expected failure. it is strange to test a test case by check nothing (only expect it not go to assert). I am not much sure about it.
> @dsanders any suggestions ?
Let me auto-generate checks then? I don't think we really need them here, however, I'm not strongly against. If it's the only problem, it does not worth such a long discussion :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136949/new/
https://reviews.llvm.org/D136949
More information about the llvm-commits
mailing list