[PATCH] D136344: [ELF][RISCV] Merge `.riscv.attributes` sections

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 20:32:48 PST 2022


MaskRay added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:596
+        // Validate arch tag contains C if and only if EF_RISCV_RVC is present.
+        if (config->eflags & EF_RISCV_RVC) {
+          Optional<StringRef> Attr =
----------------
`config->eflags` hasn't been computed at this point, so everything in this body won't fire.
I am rewriting this a la armExidx.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136344/new/

https://reviews.llvm.org/D136344



More information about the llvm-commits mailing list