[PATCH] D137707: Move "auto-init" instructions to the dominator of their users

[JF Bastien via Phabricator via llvm-commits]

jfb added a comment.

Are there any worries about moving stores that are on atomic/volatile "objects", either because the auto-init store itself is atomic/volatile, or because a subsequent access is marked as such? I don't think there's a worry because auto-init stores are technically outside the abstract machine (they "don't exist"), but I'm not 100% convinced.



================
Comment at: llvm/lib/Transforms/Utils/MoveAutoInit.cpp:119
+      if (CurrBB == UsersDominator)
+        // No early exit because we ant to compute the full set of transitive
+        // successors.
----------------
Typo "want"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137707/new/

https://reviews.llvm.org/D137707