[PATCH] D138339: [FuzzMutate] New strategy `ShuffleBlockStrategy`

[Peter Rong via Phabricator via llvm-commits]

Peter marked 2 inline comments as done.
Peter added inline comments.


================
Comment at: llvm/unittests/FuzzMutate/StrategiesTest.cpp:366
+
+  auto M = parseAssembly(Source.data(), Ctx);
+  Function *F = &*M->begin();
----------------
arsenm wrote:
> Peter wrote:
> > arsenm wrote:
> > > Module *M
> > `parseAssembly` returns a unique pointer so we don't have to explicitly free the memory. 
> > I think we are better off with `auto`. Besides, every other test did the same.
> That makes things worse. I think auto is harmful here
I understand the ambiguity can be harmful here now. I have made the change. I will change other uses in this file in another diff once this is accepted. Thanks for pointing it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138339/new/

https://reviews.llvm.org/D138339