[PATCH] D137730: [mlir][TilingInterface] Fix a crash in PartialTilingInterface for some inputs

Murali Vijayaraghavan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 14:32:30 PST 2022


vmurali added a comment.

In D137730#3944846 <https://reviews.llvm.org/D137730#3944846>, @nicolasvasilache wrote:

> `suppress` can only suppress silenceable failures, which can be ignored and leave the IR in a valid state.
> Definite failures cannot be suppressed as they leave the IR in an invalid state.
>
> What you may want is to refactor the transform to safelyreturn a silenceable failure in your use case.

I want to `suppress` a match failure (see changes in this differential). The transform pipeline should technically see the match failure and fail to perform any subsequent transformations (like how a normal pass pipeline would). I just want it to not bail out in the very end, and instead return the state the IR was in before the pipeline was applied.

More generally, if I have to apply different pipelines in some priority order (the first one to succeed will change the IR, and the rest of the pipelines will not be applied), how do I do that? (In my case, the second pipeline is a no-op transformation.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137730/new/

https://reviews.llvm.org/D137730



More information about the llvm-commits mailing list