[PATCH] D138524: llvm-reduce: Fix producing invalid reductions on ifunc

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: aeubanks, regehr, MaskRay, dexonsmith.
Herald added a subscriber: StephenFan.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

https://reviews.llvm.org/D138524

Files:
  llvm/test/tools/llvm-reduce/no-remove-ifunc-function.ll
  llvm/tools/llvm-reduce/deltas/Utils.cpp


Index: llvm/tools/llvm-reduce/deltas/Utils.cpp
===================================================================
--- llvm/tools/llvm-reduce/deltas/Utils.cpp
+++ llvm/tools/llvm-reduce/deltas/Utils.cpp
@@ -13,6 +13,7 @@
 #include "Utils.h"
 #include "llvm/IR/Constants.h"
 #include "llvm/IR/GlobalAlias.h"
+#include "llvm/IR/GlobalIFunc.h"
 
 using namespace llvm;
 
@@ -27,5 +28,7 @@
 }
 
 bool llvm::hasAliasUse(Function &F) {
-  return any_of(F.users(), [](User *U) { return isa<GlobalAlias>(U); });
+  return any_of(F.users(), [](User *U) {
+      return isa<GlobalAlias>(U) || isa<GlobalIFunc>(U);
+    });
 }
Index: llvm/test/tools/llvm-reduce/no-remove-ifunc-function.ll
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-reduce/no-remove-ifunc-function.ll
@@ -0,0 +1,27 @@
+; RUN: llvm-reduce -abort-on-invalid-reduction --delta-passes=functions --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefixes=CHECK-FINAL --input-file=%t %s
+
+; Test handling of ifunc. Make sure function reduction doesn't create
+; invalid ifunc
+
+
+; CHECK-INTERESTINGNESS: define void @no_ifunc_interesting
+
+; CHECK-FINAL: @ifunc1 = ifunc void (), ptr @has_ifunc
+; CHECK-FINAL: define void @no_ifunc_interesting() {
+; CHECK-FINAL-NOT: define
+
+ at ifunc1 = ifunc void (), ptr @has_ifunc
+
+
+define void @has_ifunc() {
+  ret void
+}
+
+define void @no_ifunc_interesting() {
+  ret void
+}
+
+define void @no_ifunc_boring() {
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138524.477298.patch
Type: text/x-patch
Size: 1581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221122/3d5b7510/attachment.bin>