[PATCH] D137725: [OpenMP][OMPIRBuilder] Mirgrate getName from clang to OMPIRBuilder

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:895
+                                     hasRequiresUnifiedSharedMemory(), "_",
+                                     "$");
   OMPBuilder.setConfig(Config);
----------------
Why do we need to pass them here at all? What's the second argument for? Doesn't it effectively tell us what the separators are?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137725/new/

https://reviews.llvm.org/D137725