[PATCH] D136169: [AMDGPU] Avoid SCC clobbering before S_CSELECT_B32

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 10:00:24 PST 2022


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

In D136169#3944366 <https://reviews.llvm.org/D136169#3944366>, @alex-t wrote:

> In D136169#3943669 <https://reviews.llvm.org/D136169#3943669>, @foad wrote:
>
>> There are still setIsDead changes and whitespace changes. Please try to strip them all out so we get a minimal patch to review.
>
> Ok.  I thought you wanted me to remove all the setIsDead calls since they are not needed anymore.

That would probably be fine, but it should be a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136169/new/

https://reviews.llvm.org/D136169



More information about the llvm-commits mailing list