[llvm] 6ed6e8e - [AMDGPU] Remove RegStrictDom variable. NFC.

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 09:09:35 PST 2022


Author: Jay Foad
Date: 2022-11-22T17:08:00Z
New Revision: 6ed6e8e3b864fc3510a91d539c7bab02018e126f

URL: https://github.com/llvm/llvm-project/commit/6ed6e8e3b864fc3510a91d539c7bab02018e126f
DIFF: https://github.com/llvm/llvm-project/commit/6ed6e8e3b864fc3510a91d539c7bab02018e126f.diff

LOG: [AMDGPU] Remove RegStrictDom variable. NFC.

D117544 removed the only substantive use of RegStrictDom. Now we can
simplify by using StrictDom for everything.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
index 606580afc3a8..626799e19081 100644
--- a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
+++ b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
@@ -1505,27 +1505,21 @@ bool WaitcntBrackets::merge(const WaitcntBrackets &Other) {
 
     StrictDom |= mergeScore(M, LastFlat[T], Other.LastFlat[T]);
 
-    bool RegStrictDom = false;
-    for (int J = 0; J <= VgprUB; J++) {
-      RegStrictDom |= mergeScore(M, VgprScores[T][J], Other.VgprScores[T][J]);
-    }
+    for (int J = 0; J <= VgprUB; J++)
+      StrictDom |= mergeScore(M, VgprScores[T][J], Other.VgprScores[T][J]);
 
     if (T == VM_CNT) {
       for (int J = 0; J <= VgprUB; J++) {
         unsigned char NewVmemTypes = VgprVmemTypes[J] | Other.VgprVmemTypes[J];
-        RegStrictDom |= NewVmemTypes != VgprVmemTypes[J];
+        StrictDom |= NewVmemTypes != VgprVmemTypes[J];
         VgprVmemTypes[J] = NewVmemTypes;
       }
     }
 
     if (T == LGKM_CNT) {
-      for (int J = 0; J <= SgprUB; J++) {
-        RegStrictDom |= mergeScore(M, SgprScores[J], Other.SgprScores[J]);
-      }
+      for (int J = 0; J <= SgprUB; J++)
+        StrictDom |= mergeScore(M, SgprScores[J], Other.SgprScores[J]);
     }
-
-    if (RegStrictDom)
-      StrictDom = true;
   }
 
   return StrictDom;


        


More information about the llvm-commits mailing list