[PATCH] D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

> Also, one reason why this slept for so long is that the libc++ review group is not on this review. Did you follow the steps in https://libcxx.llvm.org/Contributing.html#contributing-to-libc to upload the patch (in particular `arc diff`)?

I was not aware that `libc++` has its own set of rules/guidelines. I will check this out and follow up as required.

> I am not seeing any test changes or any CI configuration changes -- so is this fixing anything that libc++ can notice?

AFAICT, current tests and/or CI configurations are not affected. I just happened to need to test a static Windows build of LLVM with static `libc++` and ran into this issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136605/new/

https://reviews.llvm.org/D136605