[PATCH] D138292: [AArch64][SME]: Generate streaming-compatible code for int-minmax, fp-minmax

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-int-minmax.ll:258
 ; CHECK-NEXT:    ld1h { z1.h }, p0/z, [x1]
 ; CHECK-NEXT:    smin z0.h, p0/m, z0.h, z1.h
 ; CHECK-NEXT:    st1h { z0.h }, p0, [x0]
----------------
Did you forget to regenerate the tests? I would have expected different code after removing the vscale_range attribute, as it would require at least two smin operations for legalisation reasons.


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-int-minmax.ll:252
 
 define void @smin_v16i16(<16 x i16>* %a, <16 x i16>* %b) vscale_range(2,0) #0 {
 ; CHECK-LABEL: smin_v16i16:
----------------
sdesmalen wrote:
> All the tests with `vscale_range(2, 0)` can be removed, because these are already tested in the regular fixed-width test file.
I didn't realise all tests in this file had `vscale_range(2, 0)`, but if you remove them, please remove the attributes from the patch that adds this file.

When I left my first comment, my thinking was that there wasn't much value in this particular test, because it's behaviour was already tested by sve-fixed-length-int-minmax.ll, but at second glance there may be value because it should now be testing legalisation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138292/new/

https://reviews.llvm.org/D138292