[PATCH] D138502: [RISCV] Simplify eliminateFrameIndex in advance of reuse [nfc-ish]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 08:11:15 PST 2022


reames created this revision.
reames added reviewers: craig.topper, asb, frasercrmck, kito-cheng.
Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, bollu, simoncook, johnrusso, rbar, hiraditya, arichardson, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

The prior code intermixed several concerns - the actual materialization of the offset, the choice of destination register, and whether to prune the ADDI.  This version factors the first part out, and then reasons only about the later two.  My intention is to merge the adjustReg routine with the one from frame lowering, and then explore using the merged result to simplify frame setup and tear down.

This change is conceptually NFC, but since it results in slightly different vreg usage, the end result can change register allocation in minor ways.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138502

Files:
  llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp
  llvm/lib/Target/RISCV/RISCVRegisterInfo.h
  llvm/test/CodeGen/RISCV/rvv/addi-scalable-offset.mir
  llvm/test/CodeGen/RISCV/rvv/emergency-slot.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138502.477202.patch
Type: text/x-patch
Size: 13448 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221122/908093b4/attachment.bin>


More information about the llvm-commits mailing list