[PATCH] D138320: [lld-macho] Fix bug in CUE folding that resulted in wrong unwind table.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo marked 4 inline comments as done.
oontvoo added inline comments.


================
Comment at: lld/test/MachO/compact-unwind-foldings.s:85-86
+
+// _d is intentionally placed in between the symbols with eh_frame entries.
+// but _d should NOT have an entry in .eh_frame
+// So it shouldn't be covered by the unwind table.
----------------
int3 wrote:
> both ld64 and LLD do include an entry (with encoding 0x0) for this, right?
> 
> I'm not sure there's a way to *not* include `_d` here, since if there isn't an entry with 0x0 encoding, then the unwinder just uses the CUE at the most recent preceding address. So I think ld64 is working correctly here
right - when _d is in the middle of the range, we can't exclude it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138320/new/

https://reviews.llvm.org/D138320