[PATCH] D138469: [LoongArch] Use tablegen size for getInstSizeInBytes
Lu Weining via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 22 05:58:53 PST 2022
SixWeining accepted this revision.
SixWeining added a comment.
This revision is now accepted and ready to land.
LGTM. But tt's better be checked by @gonglingqin who wrote most of the AMO pseudos.
================
Comment at: llvm/unittests/Target/LoongArch/InstSizes.cpp:117-129
+ " dead early-clobber renamable $r10, dead early-clobber renamable "
+ "$r11 = PseudoMaskedAtomicLoadAdd32 renamable $r7, renamable $r6, "
+ "renamable $r8, 4\n"
+ " dead early-clobber renamable $r10, dead early-clobber renamable "
+ "$r11 = PseudoAtomicLoadAdd32 renamable $r7, renamable $r6\n"
+ " dead early-clobber renamable $r5, dead early-clobber renamable $r9, "
+ "dead early-clobber renamable $r10 = PseudoMaskedAtomicLoadUMax32 "
----------------
This is less readable. Could you write each instruction in one line. If clang-format fail, `clang-format off/on` may help.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138469/new/
https://reviews.llvm.org/D138469
More information about the llvm-commits
mailing list