[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

[Sam Elliott via Phabricator via llvm-commits]

lenary added a comment.

Oh, actually, I have a few nits. You can fix them on commit though.



================
Comment at: llvm/lib/Target/AArch64/AArch64.td:497
+def FeatureCSSC : SubtargetFeature<"cssc", "HasCSSC", "true",
+  "Enable Common Short Sequence Compression (CSSC) instructions">;
+
----------------
Please use the full name in parens: FEAT_CSSC (we've done this upstream for most other architectural extensions).




================
Comment at: llvm/test/MC/AArch64/armv9.4a-v94-dp.s:1
+// RUN:     llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v9.4a < %s      | FileCheck %s
+// RUN: not llvm-mc -triple aarch64-none-linux-gnu                -mattr=+v8.8a < %s 2>&1 | FileCheck --check-prefix=NO-CSSC-ERR %s
----------------
CSSC is actually a v8.9a feature, can you update this filename?


================
Comment at: llvm/test/MC/Disassembler/AArch64/armv9.4a-v94-dp.txt:1
+# RUN:     llvm-mc -triple aarch64-none-linux-gnu -disassemble -mattr=+v9.4a < %s      | FileCheck %s
+# RUN: not llvm-mc -triple aarch64-none-linux-gnu -disassemble -mattr=+v8.8a < %s 2>&1 | FileCheck --check-prefix=NO-V94A-ERR %s
----------------
And this filename too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138488/new/

https://reviews.llvm.org/D138488