[PATCH] D138476: [AMDGPU][InsertWaits] No wait for WAW for global/scratch_load
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 22 04:06:20 PST 2022
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:144
+static bool accessVMEMOnly(const MachineInstr &Inst) {
+ return SIInstrInfo::isVMEM(Inst) || SIInstrInfo::isFLATGlobal(Inst) ||
----------------
ruiling wrote:
> foad wrote:
> > I guess this is OK but it I really don't know what we mean by "VMEM" any more.
> Do you feel it better to be `updateVMCntOnly()`?
Yes, good idea.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138476/new/
https://reviews.llvm.org/D138476
More information about the llvm-commits
mailing list