[PATCH] D138401: [DAGCombiner] fold or (xor x, y),? patterns

Tue Nov 22 03:37:02 PST 2022

foad added a comment.

In D138401#3942877 <https://reviews.llvm.org/D138401#3942877>, @bcl5980 wrote:

> In D138401#3940984 <https://reviews.llvm.org/D138401#3940984>, @foad wrote:
>
>> In D138401#3940345 <https://reviews.llvm.org/D138401#3940345>, @bcl5980 wrote:
>>
>>> In D138401#3940326 <https://reviews.llvm.org/D138401#3940326>, @foad wrote:
>>>
>>>> Does instcombine do this at the IR level? Is there a need to do it in selectiondag too?
>>>
>>> Yeah, instsimplify do this. But I find some corner cases in selectiondag can trigger this code because of some logical op generated by SelectionDAG itself. So, I add all similar code in this change.
>>
>> Can you add a test that shows that happening?
>
> If you think the test is OK I can precommit the test.

Yes, please do.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138401/new/

https://reviews.llvm.org/D138401