[PATCH] D138470: [bazel] Restore libpfm as a conditional dependency for exegesis.

Tue Nov 22 01:49:14 PST 2022

gchatelet added a comment.

LGTM. Thx @aeubanks for installing `libpfm` on the CI bots.

I just have a question about disabling `Exegesis` in case `libpfm` is disabled.
FTR D119547 <https://reviews.llvm.org/D119547> uses `external` as the default policy which builds from source.

@rupprecht this patch will require a bit of integration downstream.

================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:2707
+
 cc_library(
     name = "Exegesis",
----------------
AFAIU it doesn't make sense to build `Exegesis` without `libpfm` so I would do something similar to
https://github.com/llvm/llvm-project/blob/ee82b864f2086f944f046bd00b03f30697403f8a/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel#L13-L16

This makes sure that the target is skipped when using wildcards (which is the case on CI).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138470/new/

https://reviews.llvm.org/D138470