[PATCH] D136325: [Assignment Tracking Analysis][3/*] Memory location fragment filling

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer accepted this revision.
StephenTozer added a comment.
This revision is now accepted and ready to land.

Changes LGTM.



================
Comment at: llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp:576-577
+    // written in terms of the base pointer.
+    // TODO: Remove this condition since the fragment offset doesn't always
+    // equal the offset from base pointer (e.g. for a SROA-split variable).
+    const auto DerefOffsetInBytes = getDerefOffsetInBytes(DIExpr);
----------------
Orlando wrote:
> StephenTozer wrote:
> > It looks like the condition has indeed been removed, unless the actual conditional check appears elsewhere in this pass?
> That's the ternary operator condition below.
Missed that, all good then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136325/new/

https://reviews.llvm.org/D136325