[llvm] 801c77b - [LoongArch] Support when the depth of __builtin_frame_address is greater than zero

via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 23:51:10 PST 2022


Author: gonglingqin
Date: 2022-11-22T15:29:29+08:00
New Revision: 801c77bbfabed0f5f47b3704dee8b401f4009734

URL: https://github.com/llvm/llvm-project/commit/801c77bbfabed0f5f47b3704dee8b401f4009734
DIFF: https://github.com/llvm/llvm-project/commit/801c77bbfabed0f5f47b3704dee8b401f4009734.diff

LOG: [LoongArch] Support when the depth of __builtin_frame_address is greater than zero

As discussed in D137541, it supports processing when the depth of
__builtin_frame_address is greater than 0 instead of reporting an error.
Unsafe calls rely on the '-Wframe-address' option for diagnosis.

Differential Revision: https://reviews.llvm.org/D138084

Added: 
    

Modified: 
    llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
    llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll
    llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp b/llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
index 13315c038c417..d80d292f0691e 100644
--- a/llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
+++ b/llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
@@ -256,19 +256,23 @@ SDValue LoongArchTargetLowering::lowerFRAMEADDR(SDValue Op,
     return SDValue();
   }
 
-  // Currently only support lowering frame address for current frame.
-  if (cast<ConstantSDNode>(Op.getOperand(0))->getZExtValue() != 0) {
-    DAG.getContext()->emitError(
-        "frame address can only be determined for the current frame");
-    return SDValue();
-  }
-
   MachineFunction &MF = DAG.getMachineFunction();
   MF.getFrameInfo().setFrameAddressIsTaken(true);
-
-  return DAG.getCopyFromReg(DAG.getEntryNode(), SDLoc(Op),
-                            Subtarget.getRegisterInfo()->getFrameRegister(MF),
-                            Op.getValueType());
+  Register FrameReg = Subtarget.getRegisterInfo()->getFrameRegister(MF);
+  EVT VT = Op.getValueType();
+  SDLoc DL(Op);
+  SDValue FrameAddr = DAG.getCopyFromReg(DAG.getEntryNode(), DL, FrameReg, VT);
+  unsigned Depth = cast<ConstantSDNode>(Op.getOperand(0))->getZExtValue();
+  int GRLenInBytes = Subtarget.getGRLen() / 8;
+
+  while (Depth--) {
+    int Offset = -(GRLenInBytes * 2);
+    SDValue Ptr = DAG.getNode(ISD::ADD, DL, VT, FrameAddr,
+                              DAG.getIntPtrConstant(Offset, DL));
+    FrameAddr =
+        DAG.getLoad(VT, DL, DAG.getEntryNode(), Ptr, MachinePointerInfo());
+  }
+  return FrameAddr;
 }
 
 SDValue LoongArchTargetLowering::lowerRETURNADDR(SDValue Op,

diff  --git a/llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll b/llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll
index 2ac837c1b4e54..10fcdf2004b4f 100644
--- a/llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll
+++ b/llvm/test/CodeGen/LoongArch/frameaddr-returnaddr-error.ll
@@ -16,13 +16,6 @@ define ptr @non_const_depth_returnaddress(i32 %x) nounwind {
   ret ptr %1
 }
 
-define ptr @non_zero_frameaddress() nounwind {
-; CHECK: frame address can only be determined for the current frame
-  %1 = call ptr @llvm.frameaddress(i32 1)
-  ret ptr %1
-}
-
-
 define ptr @non_zero_returnaddress() nounwind {
 ; CHECK: return address can only be determined for the current frame
   %1 = call ptr @llvm.returnaddress(i32 1)

diff  --git a/llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll b/llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll
index 7b0a4627685a5..01c9173c2e982 100644
--- a/llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll
+++ b/llvm/test/CodeGen/LoongArch/frameaddr-returnaddr.ll
@@ -33,6 +33,36 @@ define ptr @test_frameaddress_0() nounwind {
   ret ptr %1
 }
 
+define ptr @test_frameaddress_2() nounwind {
+; LA32-LABEL: test_frameaddress_2:
+; LA32:       # %bb.0:
+; LA32-NEXT:    addi.w $sp, $sp, -16
+; LA32-NEXT:    st.w $ra, $sp, 12 # 4-byte Folded Spill
+; LA32-NEXT:    st.w $fp, $sp, 8 # 4-byte Folded Spill
+; LA32-NEXT:    addi.w $fp, $sp, 16
+; LA32-NEXT:    ld.w $a0, $fp, -8
+; LA32-NEXT:    ld.w $a0, $a0, -8
+; LA32-NEXT:    ld.w $fp, $sp, 8 # 4-byte Folded Reload
+; LA32-NEXT:    ld.w $ra, $sp, 12 # 4-byte Folded Reload
+; LA32-NEXT:    addi.w $sp, $sp, 16
+; LA32-NEXT:    ret
+;
+; LA64-LABEL: test_frameaddress_2:
+; LA64:       # %bb.0:
+; LA64-NEXT:    addi.d $sp, $sp, -16
+; LA64-NEXT:    st.d $ra, $sp, 8 # 8-byte Folded Spill
+; LA64-NEXT:    st.d $fp, $sp, 0 # 8-byte Folded Spill
+; LA64-NEXT:    addi.d $fp, $sp, 16
+; LA64-NEXT:    ld.d $a0, $fp, -16
+; LA64-NEXT:    ld.d $a0, $a0, -16
+; LA64-NEXT:    ld.d $fp, $sp, 0 # 8-byte Folded Reload
+; LA64-NEXT:    ld.d $ra, $sp, 8 # 8-byte Folded Reload
+; LA64-NEXT:    addi.d $sp, $sp, 16
+; LA64-NEXT:    ret
+  %1 = call ptr @llvm.frameaddress(i32 2)
+  ret ptr %1
+}
+
 define ptr @test_returnaddress_0() nounwind {
 ; LA32-LABEL: test_returnaddress_0:
 ; LA32:       # %bb.0:


        


More information about the llvm-commits mailing list