[PATCH] D136169: [AMDGPU] Avoid SCC clobbering before S_CSELECT_B32
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 21 22:53:17 PST 2022
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:1632
+ .addImm(-ScratchOffsetRegDelta);
+ I->getOperand(3).setIsDead();
}
----------------
Do you still need all these setIsDead changes? In any case can you remove them from *this* patch, so it just contains the essential changes? Maybe put them all in a separate patch, if there is still any need for them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136169/new/
https://reviews.llvm.org/D136169
More information about the llvm-commits
mailing list