[PATCH] D137890: Add install targets for gtest

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 21:12:08 PST 2022


tstellar added a comment.

In D137890#3942748 <https://reviews.llvm.org/D137890#3942748>, @mgorny wrote:

> I'll try to test this today. I suppose the main idea would be to enable `LLVM_INSTALL_GTEST`, then stop unpacking `third-party` directory when building other packages, correct? Perhaps it would make sense to update the checks like the one in clang while doing that:
>
>   if( CLANG_INCLUDE_TESTS )
>     if(EXISTS ${LLVM_THIRD_PARTY_DIR}/unittest/googletest/include/gtest/gtest.h)
>       add_subdirectory(unittests)
>       ...

I submitted the clang patch here: D138472 <https://reviews.llvm.org/D138472>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137890/new/

https://reviews.llvm.org/D137890



More information about the llvm-commits mailing list