[PATCH] D138470: [bazel] Restore libpfm as a conditional dependency for exegesis.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 19:36:18 PST 2022


rupprecht created this revision.
rupprecht added reviewers: gchatelet, GMNGeoffrey, aeubanks, courbet.
Herald added a subscriber: mstojanovic.
Herald added a project: All.
rupprecht requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We used to have `pfm` built into exegesis, although since it's an external dependency we marked it as a manual target. Because of this we didn't have buildbot coverage and so we removed it in D134510 <https://reviews.llvm.org/D134510> after we had a few breakages that weren't caught. This adds it back, but with three possible states similar to the story with `mpfr`, i.e. it can either be disabled, built from external sources (git/make), or use whatever `-lpfm` is installed on the system.

This change is modeled after D119547 <https://reviews.llvm.org/D119547>. Like that patch, the default is off (matching the status quo), but unlike that patch we don't enable it for CI because IIRC we don't have the package installed there, and building from source might be expensive. We could  enable it later either after installing it on buildbot machines or by measuring build cost and deeming it OK.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138470

Files:
  utils/bazel/WORKSPACE
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
  utils/bazel/third_party_build/pfm.BUILD

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138470.477052.patch
Type: text/x-patch
Size: 5306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221122/1a8a4733/attachment.bin>


More information about the llvm-commits mailing list