[PATCH] D138466: Don't use Optional::getPointer (NFC)

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 19:02:27 PST 2022


kazu added a comment.

Thanks for the review!

In D138466#3942622 <https://reviews.llvm.org/D138466#3942622>, @MaskRay wrote:

> `getPointer` asserts `hasValue`, so `&*` is safe,

Yes.  `operator*` also asserts `hasVal` via `value()`, so we maintain the same level of safety.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138466/new/

https://reviews.llvm.org/D138466



More information about the llvm-commits mailing list