[PATCH] D138462: [llvm-mca] Fix class dominance warnings for parseCodeRegions
Michael Maitland via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 21 16:14:00 PST 2022
michaelmaitland added a comment.
@RKSimon, I'm not quite sure how to make one of these MSVC builds. But I used godbolt.org with the following snippet to verify the issue went away:
#include <stdio.h>
struct CRG {
virtual void func() = 0;
};
struct AnalysisCRG : public virtual CRG {};
struct InstCRG : public virtual CRG {};
struct AsmCRG : public virtual CRG {
void func() { printf("dominant::func\n"); }
};
struct AsmAnalysisCRG final : public AnalysisCRG, public AsmCRG {
void func() { AsmCRG::func(); }
};
struct AsmInstCRG final : public InstCRG, public AsmCRG {
void func() { AsmCRG::func(); }
};
int main() {
AsmAnalysisCRG a;
AsmInstCRG i;
a.func(); // C4250 should go away now
i.func(); // C4250 should go away now
}
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138462/new/
https://reviews.llvm.org/D138462
More information about the llvm-commits
mailing list