[PATCH] D138456: Add new option choices for print-changed that do not output llc changes.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/IR/PrintPasses.h:37
+  OptDotCfgVerbose,
+  OptDotCfgQuiet
 };
----------------
The number of modes is massive. Shall we use another option to indicate the intent (only show non-codegen passes)?


================
Comment at: llvm/lib/CodeGen/MachineFunctionPass.cpp:131
       switch (PrintChanged) {
-      case ChangePrinter::None:
+      default:
         llvm_unreachable("");
----------------
I think we should keep enumerating all values to ensure a new mode does not silently get unhandled here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138456/new/

https://reviews.llvm.org/D138456