[PATCH] D138355: [gn build] Add build files for //bolt

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 12:24:46 PST 2022


thakis added inline comments.


================
Comment at: llvm/utils/gn/secondary/BUILD.gn:8
+    # FIXME: Add this after testing that it builds on linux/mac/win.
+    #"//bolt/test",
     "//clang-tools-extra/clangd/test",
----------------
aeubanks wrote:
> if you've already tested on mac, add this below under `if (current_os == "macos")`?
It doesn't build on mac without D138423. But yes, let's just land that first and then I'll do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138355/new/

https://reviews.llvm.org/D138355



More information about the llvm-commits mailing list