[PATCH] D136847: [RISCV][NFC] Mark rs1 in most memory instructions as memory operand.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 11:56:41 PST 2022


reames added a comment.

In D136847#3930781 <https://reviews.llvm.org/D136847#3930781>, @dybv-sc wrote:

> All fixed now. Ping for review.

Why?  Craig has given an LGTM and later comments were style only.  Our usual take is that LGTM still holds and you can land.

(I have not looked at this patch at all, just making a process comment.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136847/new/

https://reviews.llvm.org/D136847



More information about the llvm-commits mailing list