[PATCH] D138334: Improve llvm-symbolizer search logic for symlink

jeffrey tan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 09:46:09 PST 2022


yinghuitan added a comment.

@labath, thanks. I wish I can control the symlink deployment process, but unfortunately I can't. I think it is generally preferable to make lldb crash handler deal correctly with it. 
I agree we do not want to regress any of existing behavior. That's why the patch only adds an extra search path for `sys::findProgramByName` which will prefer the executable parent first and fallback to try the second added path (real path from symlink) if failed to find in first path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138334/new/

https://reviews.llvm.org/D138334



More information about the llvm-commits mailing list