[PATCH] D138431: [DirectX] Fix shared libraries build

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

I think I would broadly classify that there are two problems you're fixing here:
(1) Under-specified dependencies.
(2) A cyclic dependency on PointerTypeAnalysis

I agree with how you've addressed (1), I think breaking PointerTypeAnalysis into its own library is less than ideal.

We have a growing set of IR passes in the DirectX backend, and I expect that number of passes to keep growing for a while. It probably just makes more sense to create a `DirectXIRPasses` library and move PointerTypeAnalysis to that library.

I don't want to push you to clean up all our code organization in order to fix the bug you're working on. If you change the PointerTypeAnalysis library name to DirectXIRPasses I'll approve this and finish the code reorganization when I get a chance in a week or two.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138431/new/

https://reviews.llvm.org/D138431