[PATCH] D137970: [RISCV] Transform fixable instruction in place in RISCVSExtWRemoval. NFC

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 08:40:57 PST 2022


reames added a comment.

I'm not sure this is right.  The problem is that the original instruction can have flags that indicate e.g. no-wrap or no-inf.  Previously, those were implicitly dropped.  After the transform, we have a different instruction semantic, are you sure those flags are always preserved?  That seems like a non-obvious claim.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137970/new/

https://reviews.llvm.org/D137970



More information about the llvm-commits mailing list