[PATCH] D138281: [AArch64][SME]: Generate streaming-compatible code for fp_to_int and int_to_fp, fp-convert, trunk.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

LGTM with nit addressed



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15435-15439
+  if (Subtarget->forceStreamingCompatibleSVE())
+    return SDValue();
+
   if (!Subtarget->hasNEON())
     return SDValue();
----------------
nit: These conditions can be combined into:

   if (!Subtarget->hasNEON() || Subtarget->forceStreamingCompatibleSVE())
     return SDValue();



================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-trunc.ll:609
-; CHECK-NEXT:    ptrue p0.s, vl2
-; CHECK-NEXT:    xtn v0.2s, v0.2d
 ; CHECK-NEXT:    ldp q2, q3, [x0]
----------------
I think it's only the XTN here that's not legal, so I expect this test to be improved by the patch that implements the lowering for TRUNCATE. Do you already have a patch for that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138281/new/

https://reviews.llvm.org/D138281