[PATCH] D136344: [ELF][RISCV] Merge `riscv.attributes` sections from all input files

[Elena Lepilkina via Phabricator via llvm-commits]

eklepilkina added inline comments.


================
Comment at: lld/ELF/Driver.cpp:2821
+
+    // Collect all `.riscv.attributes` sections.
+    SmallVector<InputSectionBase *, 0> attributesSections;
----------------
MaskRay wrote:
> "Combine RISCV attributes." and this comment have the same meaning. Just place the comment before `if`.
> 
> This block does not belong to generic code. Move it to Arch/RISCV.cpp
Replaced to copy_if, this comment was connected with creating container with all riscv attributes sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136344/new/

https://reviews.llvm.org/D136344