[llvm] 5a62e6b - [Test] One more test for IndVars, showing imperfect work with context

Max Kazantsev via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 00:15:08 PST 2022


Author: Max Kazantsev
Date: 2022-11-21T15:14:48+07:00
New Revision: 5a62e6b485e1df12d85d6e15dfe708113e09feef

URL: https://github.com/llvm/llvm-project/commit/5a62e6b485e1df12d85d6e15dfe708113e09feef
DIFF: https://github.com/llvm/llvm-project/commit/5a62e6b485e1df12d85d6e15dfe708113e09feef.diff

LOG: [Test] One more test for IndVars, showing imperfect work with context

Added: 
    

Modified: 
    llvm/test/Transforms/IndVarSimplify/turn-to-invariant.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/IndVarSimplify/turn-to-invariant.ll b/llvm/test/Transforms/IndVarSimplify/turn-to-invariant.ll
index 242f96b8bb5d..9672a358f7ae 100644
--- a/llvm/test/Transforms/IndVarSimplify/turn-to-invariant.ll
+++ b/llvm/test/Transforms/IndVarSimplify/turn-to-invariant.ll
@@ -120,6 +120,69 @@ failed_2:
   ret i32 -2
 }
 
+; TODO: Same as @test_litter_conditions, but all conditions are computed in
+;       header block. Make sure we infer fact from the right context.
+;       https://alive2.llvm.org/ce/z/JiD-Pw
+define i32 @test_litter_conditions_bad_context(i32 %start, i32 %len) {
+; CHECK-LABEL: @test_litter_conditions_bad_context(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    br label [[LOOP:%.*]]
+; CHECK:       loop:
+; CHECK-NEXT:    [[IV:%.*]] = phi i32 [ [[START:%.*]], [[ENTRY:%.*]] ], [ [[IV_NEXT:%.*]], [[BACKEDGE:%.*]] ]
+; CHECK-NEXT:    [[ZERO_CHECK:%.*]] = icmp ne i32 [[IV]], 0
+; CHECK-NEXT:    [[FAKE_1:%.*]] = call i1 @cond()
+; CHECK-NEXT:    [[AND_1:%.*]] = and i1 [[ZERO_CHECK]], [[FAKE_1]]
+; CHECK-NEXT:    [[IV_MINUS_1:%.*]] = add i32 [[IV]], -1
+; CHECK-NEXT:    [[RANGE_CHECK:%.*]] = icmp ult i32 [[IV_MINUS_1]], [[LEN:%.*]]
+; CHECK-NEXT:    [[FAKE_2:%.*]] = call i1 @cond()
+; CHECK-NEXT:    [[AND_2:%.*]] = and i1 [[RANGE_CHECK]], [[FAKE_2]]
+; CHECK-NEXT:    br i1 [[AND_1]], label [[RANGE_CHECK_BLOCK:%.*]], label [[FAILED_1:%.*]]
+; CHECK:       range_check_block:
+; CHECK-NEXT:    br i1 [[AND_2]], label [[BACKEDGE]], label [[FAILED_2:%.*]]
+; CHECK:       backedge:
+; CHECK-NEXT:    [[IV_NEXT]] = add i32 [[IV]], -1
+; CHECK-NEXT:    [[LOOP_COND:%.*]] = call i1 @cond()
+; CHECK-NEXT:    br i1 [[LOOP_COND]], label [[DONE:%.*]], label [[LOOP]]
+; CHECK:       done:
+; CHECK-NEXT:    [[IV_LCSSA2:%.*]] = phi i32 [ [[IV]], [[BACKEDGE]] ]
+; CHECK-NEXT:    ret i32 [[IV_LCSSA2]]
+; CHECK:       failed_1:
+; CHECK-NEXT:    ret i32 -1
+; CHECK:       failed_2:
+; CHECK-NEXT:    ret i32 -2
+;
+entry:
+  br label %loop
+
+loop:
+  %iv = phi i32 [%start, %entry], [%iv.next, %backedge]
+  %zero_check = icmp ne i32 %iv, 0
+  %fake_1 = call i1 @cond()
+  %and_1 = and i1 %zero_check, %fake_1
+  %iv.minus.1 = add i32 %iv, -1
+  %range_check = icmp ult i32 %iv.minus.1, %len
+  %fake_2 = call i1 @cond()
+  %and_2 = and i1 %range_check, %fake_2
+  br i1 %and_1, label %range_check_block, label %failed_1
+
+range_check_block:
+  br i1 %and_2, label %backedge, label %failed_2
+
+backedge:
+  %iv.next = add i32 %iv, -1
+  %loop_cond = call i1 @cond()
+  br i1 %loop_cond, label %done, label %loop
+
+done:
+  ret i32 %iv
+
+failed_1:
+  ret i32 -1
+
+failed_2:
+  ret i32 -2
+}
+
 ; TODO: This test is equivalent to @test_simple_case, with only 
diff erence
 ;       that both checks are merged together into one 'and' check. This
 ;       should not prevent turning the range check into invariant.


        


More information about the llvm-commits mailing list