[PATCH] D138401: [DAGCombiner] fold or (xor x, y),? patterns

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 20 23:25:35 PST 2022


bcl5980 added a comment.

In D138401#3940326 <https://reviews.llvm.org/D138401#3940326>, @foad wrote:

> Does instcombine do this at the IR level? Is there a need to do it in selectiondag too?

Yeah, instsimplify do this. But I find some corner cases in selectiondag can trigger this code because of some logical op generated by SelectionDAG itself. So, I add all similar code in this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138401/new/

https://reviews.llvm.org/D138401



More information about the llvm-commits mailing list